IPlug Community effort

[captain caveman]

Yes, that was it Tale - thanks. I've updated the file in the stash the link above goes to and added a comment in the code next to that control. The graphics for it still aren't exactly what the component images to the left should stack up to though. Maybe the mask has to be a certain colour, but that still probably wouldn't explain why the cross hair top section turns into an outline.

Looking at the rotation of it too, it appears to exhibit the same wobbling and fuzzy sides that IKnobRotaterControl shows. I have noticed whilst doing my plugins that even the yOffsetZeroDeg doesn't correct a wobbly knob and the surrounds aren't as defined as when a multi-image is used with IKnobMultiControl. I have tried images with dimensions of odd and even numbers of pixels but can't seem to tame that control.

That's possibly one for another time, but I don't want to leave this control looking the way it does.

[olilarkin]

i tried it captain. seems good. i noticed as well as the fuzzyness maybe the rotation is slightly off in IKnobRotatorControl. Maybe your knob graphic is not totally centred?

re the fuzzyness, there is something wrong with IGraphicsLice:: DrawRotatedBitmap() or the lice function it calls.

re ICaptionControl, usually you would use this to display the value of a slider or knob. At the moment one of the issues that we need to address in wdl-ce is the way that multiple controls linked to the same parameter update each other. I haven't actually used ICaptionControl myself for the readout displays in my plugins... I just made one control that has a text display/editing area. Probably for the IPlugControlsDemo you could add another control to the ICaptionControl area and in OnParamChange() set the ICaptionControl dirty when the parameter value changes.

so are you going to push the source to the examples branch on github? i can add in the missing controls if you like

[captain caveman]

Yes, that would be good. I have wrestled with GitHub previously and didn't "get it" so instead of wasting time and potentially destroying the wdl-CE project it'd probably be better if I just linked to a .zip package...

http://jof.org.uk/Share/IControlExample.zip

Much obliged. :

[Cubits]

I will be making contributions soon just been busy with a few things still got to get my head round GIT aswell lol

[olilarkin]

i have added the code to the examples branch. still cant get it working on codeblocks though

[HoRNet]

ok i've started working on the new version of my channelstrip and linking against wdl-ce.

i had to add a method to IControl that i'll be going to submit for review once i'm happy, but i've found a problem with the ICaptionControl with Cocoa hosts such as Reaper on OSX.

I have a IKnobMultiControl and an ICaptionControl bound to the same parameter index, now on Live 7 (a carbon host) i can edit the iCaptionControl and the IKnobMultiControl is updated accordingly, on Reaper (Cocoa) the input from the ICaptionControl is ignored. I've run the debug and found where the problem is, but my Objective-C is really not up to the task...

- (void) controlTextDidEndEditing: (NSNotification*) aNotification
{
  //char* txt = (char*)[[mParamEditView stringValue] UTF8String];
  
  NSInteger vi = -1;
  if ([mParamEditView respondsToSelector: @selector(indexOfSelectedItem)] == YES)
    vi = (NSInteger)[mParamEditView indexOfSelectedItem];
  if (vi != -1)
    mEdControl->SetValueFromUserInput(mEdParam->GetNormalized((double)vi));
  //else
    //mGraphics->SetFromStringAfterPrompt(mEdControl, mEdParam, txt);
  
  EndUserInput(self);
  [self setNeedsDisplay: YES];
}

in this method from IGraphicsCocoa.mm vi is always -1 since the check for the message respond fail. The problem is that i don't know why it fails, that's where my Objective-C ends...

any help?

[Tale]

The problem is that the code to handle "raw" text input (i.e. not from a drop-down list) is commented out. In my Git repository this handled by IGraphics::SetFromStringAfterPrompt(), but the current wdl-ce repository doesn't have such a method.

I guess you could hack the missing code into the current wdl-ce code like this:

- (void) controlTextDidEndEditing: (NSNotification*) aNotification
{
  char* txt = (char*)[[mParamEditView stringValue] UTF8String];
  
  NSInteger vi = -1;
  if ([mParamEditView respondsToSelector: @selector(indexOfSelectedItem)] == YES)
    vi = (NSInteger)[mParamEditView indexOfSelectedItem];
  if (vi != -1)
    mEdControl->SetValueFromUserInput(mEdParam->GetNormalized((double)vi));
  else
  {
    double v = atof(txt);
    if (mEdParam->DisplayIsNegated()) v = -v;
    mEdControl->SetValueFromUserInput(pParam->GetNormalized(v));
  }
  
  EndUserInput(self);
  [self setNeedsDisplay: YES];
}

[olilarkin]

yes it's commented out because i have done a lot of work on this stuff, and implemented the text entry / menu stuff a bit differently. just need to find the time to add it to wdl-ce.

[HoRNet]

Thank you Tale, what you wrote makes a lot of sense and in fact works fine.

There is still a problem, the ICaptionControl is updated and the param takes the new value, but the knob is not redrawn to te new value. In Carbon hosts this works fine and the knob is updated, so i fired the debugger and had a look line by line to the carbon code. but i don't see anything special the drawing is made with this code

if (mIsComposited)
  {
    //IRECT* pR = mEdControl->GetRECT();
    //HIViewSetNeedsDisplayInRect(mView, &CGRectMake(pR->L, pR->T, pR->W(), pR->H()), true);
    HIViewSetNeedsDisplay(mView, true);
  }
  else
  {
    mEdControl->SetDirty(false);
    mEdControl->Redraw();
  }

now Live is a composited host so the only code that is called is

 HIViewSetNeedsDisplay(mView, true);

that i think is the Carbon equivalent for the Cocoa

 [self setNeedsDisplay: YES];

but the Carbon ui is updated, the Cocoa one no, am I missing something?

[HoRNet]

sorry guys, forget my last message, it's not a Cocoa / Carbon issue.

I was testing with Live that after setting a parameter from the plugin informing the host, it sends back the updated value to the plugin, this updates my knob control.

I tested the plugin with an old copy of Tracktion (Carbon) and the knob is not updating, because just like Reaper it doesn't sends the value back to my plugin

[cerberus]

Originally Posted by cerberus

windows... ...the user input does not take.

a solution for this (if you are using wdl-ce) is to change line 688 in IGraphicsWin.cpp (IGraphicsWin::CreateTextEntry) from:

mParamEditWnd = CreateWindow("EDIT", pString, WS_CHILD | WS_VISIBLE | editStyle ,

to:

mParamEditWnd = CreateWindow("EDIT", pString, WS_CHILD | WS_VISIBLE | ES_MULTILINE|editStyle ,

also, the text box has it's own mousewheel response... it could be a nice feature, but i found
the behavior confused me at first. it can be disabled by commenting out:

IGraphicsWin.cpp line 207

pGraphics->mParamEditMsg = kCancel;

IGraphicsCocoa.mm line 242

if(mTextFieldView) [self endUserInput ];

IGraphicsCarbon.cpp line 178

if (_this->mTextFieldView) _this->EndUserInput(false);

special thanks to ArdeII for these!
imo, everyone should try Kirnu (his cool, friendly, and free arpeggiator plug-in)
and submit their wildest feature requests for a future version :-)

[Tale]

Originally Posted by olilarkin

i had a go at doing what you said...

see https://github.com/olilarkin/wdl-ce/...smod/WDL/IPlug

I have also had a go at this, and I have now succesfully removed IGraphicsLice from my WDL/IPlug repository. I have split up the changes in 3 seperate commits:

ddb596c IPlug: Merged IGraphicsLice into IGraphics.
e67a0f8 IPlug: Removed IGraphicsLice from project files.
0bf285c IPlugExample.xcodeproj: Removed IGraphicsLice.

I have tried to keep things as clean as possible, so regardless of which WDL/IPlug your are following you should be able to cherry-pick the first commit, which contains the bulk of the changes. You could skip the other 2 commits, provided that you remove IGraphicsLice.h and IGraphicsLice.cpp from your project files yourself.

BTW, it seems that these changes have quite an impact on file size: The Windows DLL for my ComboV project is now almost 100 kB smaller, and the Mac OS X VST is about 300 kB smaller.

[olilarkin]

anyone still interested in wdl-ce? I am pretty tired of doing 95% of the work - and I am starting to think I should just focus on my own repo.

If anyone fancy's doing some work on it, I would suggest a good next step would be to look at bringing it Tale's font and IGraphics mods.

The examples that i have been working on are nearly ready to be merged to the main branch i think, but need a little bit more work.

oli

[junioreq]

Sorry I cannot contribute. Would REALLY love to, but I'm still in newbie status with Obj coding. Believe me though, your efforts are well noted and I and some other folks do check your updates regularly.

I thought this would take off a bit more, but as I don't contribute, I probably shouldn't comment on that. It's not totally relevant to your post again, but I want to thank you publicly for what you have done.

[cerberus]

my plug-in is near release. i couldn't have had the features i wanted without
wdl-ce, such as the text entry, which is working properly on both windows
and osx thanks to your efforts. i'm new to coding, so the best i can offer
to the community and to cockos is the plug-in itself. it will be for sale,
but anyone who contributed to wdl-ce, and probably reaper users
as well may have it for free (still in beta at the moment), i want
to say how much i appreciate your help too, oli!

[HoRNet]

I've completed som mods to the WDL for my own plugin ho can i contribute them to the project? how the review is done?

[bvesco]

Did you fork from the WDL-CE repo on github?

[HoRNet]

yes, but it was some time ago, i don't think i'm current, better merge a new wdl-ce in my repo before pushing my changes to git hub? (actually i hav them only on my local hard drive)

[olilarkin]

I think you need to fork wdlce on github, check out that repo to your local machine , add your changes, then push them to your github and make a pull request to merge back to wdlce

[HoRNet]

ok i think i'll update my repo and do a pull request, but i cannot guarantee anything, never done that before (i use git for all my projects, but neve rused in a collaborative manner, so i don't know how to do a pull request )

[bvesco]

The pull request thing is pretty simple after you're used to it. It can be confusing the first time you do it. Maybe we can get on chat sometime when you're ready to do it.