A little bug in AAX, PLUG_MFR_PT

[earlevel]

Examples imply that the developer can gives multiple versions for the manufacturer name, allowing the host (Pro Tools) to choose a version of appropriate size. The AAX library code makes this assumption too, calling SetManufacturerName for each newline-delineated substring. But this is not correct, apparently.

First, the AAX SDK uses "Add..." for parameters than can have multiple versions of different string lengths. For these, the SDK docs specifically note that the function can be called multiple times to set multiple versions. Note this parameter corresponds to a "Set..." function (SetManufacturerName), and the docs do not indicate that it can be called multiple times.

For instance, in the IPlugCOntrols example:

#define PLUG_MFR_PT "AcmeInc\nAcmeInc\nAcme"
#define PLUG_NAME_PT "IPlugControls\nIPCT"

The first line (I'm sure it was intended to be "Acme Inc\nAcmeInc\nAcme") will only result in the manufacturer name set to "Acme" in Pro Tools, corresponding to the last substring—the last call to SetManufacturerName. (I had used '#define PLUG_MFR_PT "Line 6\nLine6\nLin6"', which resulted in an effects menu of "Lin6" when PT prefs were set to sort effects by manufacturer. The correct def should be '#define PLUG_MFR_PT "Line 6"'.)

The second line will work as intended, setting two versions of the plugin name, "IPlugControls" and "IPCT".