Curious Issue

[Retro]

While working on my theme I ran into a curious issue.



Notice how the MSR is different on the EZdrummer channel than the other two. The EZdrummer channel is off. I was having problems with certain MCP channels not displaying correctly -- meters not displaying correctly and other stuff. I thought it was a programming error on my part or missing graphics files. I began checking this and that, and that and this. Here and there and there and everywhere, and pulling my hair out (and believe me I have less and less of that stuff to spare these days!). Then I noticed that I had one instance correctly displaying and another not. The one that did not was the EZdrummer channel. I don't know if this is a virtual instrument issue or what, but I thought it was a curious issue. Has anyone else ran into this?

[lucas_LCS]

sounds like a a coding issue.
did you get this figured out?

::

[Retro]

Originally Posted by lucas_LCS

sounds like a a coding issue.
did you get this figured out?

::

Never figured it out. It only goes wacky when EZdrummer is involved. Displays fine otherwise. Have not checked it with other VSTI's, yet. Got busy with other things and never got back to it because I assumed it was more than a WALTER issue.

Edit: I did some testing and it occurs when a VSTi is routed to multiple outputs. I loaded Rayzoon's Jamstix w/o multiple routing and everything was fine, but when I loaded it again and let Reaper build routing, I had the same issue.

[lucas_LCS]

found several issues:

1) theme is using the wrong image files
2) image files are misnamed (my apologies)
you can download the corrected files from here:
MSR.zip

3) size code for images are incorrect on the Bellaire layouts.
All IO sized @ 31x11 should be 28x11 with H position changed to 15



:

Issues unrelated to IO:
============================
1) File management
There are a lot unneeded files in the release version of the theme.
It's your first theme, so I'm guessing you weren't sure what to keep.
make a backup before starting.
- remove any file with "Copy" in the name.
- remove any file in the Master folder that doesn't start with MCP.
- Bellaire Fx Send folder has 2 knob stacks that are misnamed and so they are not being used.
Deleting them will save you 110KB

You only have one ENV layout.
delete all files that start with ENVCP from the following sub-folders:
- Bellaire FX Send
- Bellaire TCP
- Bellaire
- Master

Remove unused duplicate files:
- delete files starting with GEN, GLOBAL ITEM & TOOLBAR from any of the sub-folders.
Those files should only need to be in the main image folder.

Doing this brought brought the theme size down to almost 2MB
Zipping it one more time brought to 1.69MB.
This will allow you to distribute the theme in one file.

Additional notes:
going forward, my suggestion would be to:
- only add files to a sub-folder as needed to insure images are not duplicated accidentally.
- organize folders to maximise using the same images as much as possible.
using the Bellaire Layouts as an example:
- use one folder for the main layout and sub-folders in that folder for the other layouts based on Bellaire.
This way, the sub-folders only need to contain files that are different from the main Bellaire layout.
Bellaire
- Red_Fader
- Blue_Fader
- FX Sends
- FX Sends_Blue_Fader
- FX Sends_Blue_Fader
- Slim_Blue_Fader
- Slim_Blue_Fader


::

[lucas_LCS]

code issues:
=============
The current code is actually reading the TCP Bellaire layout code as the default.
the code for the Bellaire layout needs to be in between the Layout & Endlayout statements.
The layouts for the fader colors needs to be inserted before the Endlayout statement of the layout they are related to.

; ------------ BELLAIRE TCP -------------

Layout "Bellaire TCP" "Bellaire TCP"

clear tcp.*
set tcp.size		[311 90 242]
front tcp.foldercomp

Set tcp.label - [4 4 w 16] [0 0 141 0]
set tcp.label.color 	?recarm [155 0 0] [194 204 204] 
set tcp.label.margin 	[6 1 1 3]
set tcp.foldercomp	[290 0 20 20 1 0 1 0]
set tcp.folder 		[290 68 20 20 1 1 1 1] 

set tcp.io		[174 4 54 16 1 0 1 0]
set tcp.solo		[227 4 26 16 1 0 1 0]
set tcp.mute		[253 4 26 16 1 0 1 0]


set tcp.recarm		[6 24 15 16]
set tcp.recmon		[6 46 11 16]
set tcp.recmode		[17 46 16 16]

set tcp.meter.readout.color 		[0] 
set tcp.meter.vu.div 			[1]
set tcp.meter - [30 24 w 16] [0 0 65 0]

set tcp.fxin		[100 46 27 16 1 0 1 0]
set tcp.recinput	[127 46 79 16 1 0 1 0]
set tcp.recinput.color	?recarm [155 0 0] [124 124 122]
set tcp.recinput.font 	[4]
set tcp.recinput.margin [0 0 0 0 .5 1 0 1 0]
set tcp.fxbyp		[206 46 11 16 1 0 1 0]
set tcp.fx		[217 46 16 16 1 0 1 0]
set tcp.env		[233 46 44 16 1 0 1 0] 		

set tcp.volume 		trackpanmode<4 [0 66 185 16 0 0 1 0] [0 66 140 16 0 0 1 0]
set tcp.volume.label	trackpanmode<4 [180 66 42 17 1 0 1 0] [135 66 42 17 1 0 1 0]
set tcp.volume.label.margin 		[3 0 3 0 0.5] 

;((>Pan<))
set tcp.pan             trackpanmode<4 [226 66 19 19 1 0 1 0] [178 66 19 19 1 0 1 0] 
set tcp.pan.label	trackpanmode<4 [239 67 37 17 1 0 1 0] [191 67 37 17 1 0 1 0]
set tcp.pan.label.margin [8 0 4 0]	

set tcp.width		trackpanmode>4 [229 66 19 19 1 0 1 0]

set tcp.width.label 		trackpanmode>4 [242 67 37 17 1 0 1 0]
set tcp.width.label.margin 	[8 0 4 0]


	Layout "Bellaire TCP Blue Fader" "Bellaire TCP/Blue Fader"
	set tcp.size	[311 90 242]
	EndLayout

	Layout "Bellaire TCP Green Fader" "Bellaire TCP/Green Fader"
	set tcp.size	[311 90 242]
	EndLayout

	Layout "Bellaire TCP Yellow Fader" "Bellaire TCP/Yellow Fader"
	set tcp.size	[311 90 242]
	EndLayout

	Layout "Bellaire TCP Red Fader" "Bellaire TCP/Red Fader"
	set tcp.size	[311 90 242]
	EndLayout

EndLayout

you have the same issues happening with the El Dorado Channel Strip layout for the MCP.

::

[Retro]

Originally Posted by lucas_LCS

found several issues:

1) theme is using the wrong image files
2) image files are misnamed (my apologies)
you can download the corrected files from here:
MSR.zip

3) size code for images are incorrect on the Bellaire layouts.
All IO sized @ 31x11 should be 28x11 with H position changed to 15



:

Issues unrelated to IO:
============================
1) File management
There are a lot unneeded files in the release version of the theme.
It's your first theme, so I'm guessing you weren't sure what to keep.
make a backup before starting.
- remove any file with "Copy" in the name.
- remove any file in the Master folder that doesn't start with MCP.
- Bellaire Fx Send folder has 2 knob stacks that are misnamed and so they are not being used.
Deleting them will save you 110KB

You only have one ENV layout.
delete all files that start with ENVCP from the following sub-folders:
- Bellaire FX Send
- Bellaire TCP
- Bellaire
- Master

Remove unused duplicate files:
- delete files starting with GEN, GLOBAL ITEM & TOOLBAR from any of the sub-folders.
Those files should only need to be in the main image folder.

Doing this brought brought the theme size down to almost 2MB
Zipping it one more time brought to 1.69MB.
This will allow you to distribute the theme in one file.

Additional notes:
going forward, my suggestion would be to:
- only add files to a sub-folder as needed to insure images are not duplicated accidentally.
- organize folders to maximise using the same images as much as possible.
using the Bellaire Layouts as an example:
- use one folder for the main layout and sub-folders in that folder for the other layouts based on Bellaire.
This way, the sub-folders only need to contain files that are different from the main Bellaire layout.
Bellaire
- Red_Fader
- Blue_Fader
- FX Sends
- FX Sends_Blue_Fader
- FX Sends_Blue_Fader
- Slim_Blue_Fader
- Slim_Blue_Fader


::

Thank you for taking the time to analyze this. I really do appreciate it.

There was lots of duplication and missteps along the way that got left in the project that was a result of my mistakes and learning. Approaching the finish-line after a month of long hours hacking at this, I was eager (too eager) to release it and didn't scrub nearly it as diligently as I should and I am still trying to fully wrap my mind around all the intricacies of Walter code.

Again, thank you for all your assistance along the way, there is so much to learn about this coding stuff. I will go back and scrub this some more. I already have plans to replace a few images that don't translate well on my 4k monitor o
in my studio and ideas for RetroSonic MKII.

I have started work on Hummingbird. It is a build from scratch which alleviates the problem of trying to figuring what to do with preexisting stuff and how to fit your own stuff in with it (which was a major challenge in the last build, especially when I was totally lost to begin with ).

Edit: Restructured and eliminated duplication and unnecessary files as recommended.

[Retro]

Originally Posted by lucas_LCS

code issues:
=============
The current code is actually reading the TCP Bellaire layout code as the default.
the code for the Bellaire layout needs to be in between the Layout & Endlayout statements.
The layouts for the fader colors needs to be inserted before the Endlayout statement of the layout they are related to.

; ------------ BELLAIRE TCP -------------

Layout "Bellaire TCP" "Bellaire TCP"

clear tcp.*
set tcp.size		[311 90 242]
front tcp.foldercomp

Set tcp.label - [4 4 w 16] [0 0 141 0]
set tcp.label.color 	?recarm [155 0 0] [194 204 204] 
set tcp.label.margin 	[6 1 1 3]
set tcp.foldercomp	[290 0 20 20 1 0 1 0]
set tcp.folder 		[290 68 20 20 1 1 1 1] 

set tcp.io		[174 4 54 16 1 0 1 0]
set tcp.solo		[227 4 26 16 1 0 1 0]
set tcp.mute		[253 4 26 16 1 0 1 0]


set tcp.recarm		[6 24 15 16]
set tcp.recmon		[6 46 11 16]
set tcp.recmode		[17 46 16 16]

set tcp.meter.readout.color 		[0] 
set tcp.meter.vu.div 			[1]
set tcp.meter - [30 24 w 16] [0 0 65 0]

set tcp.fxin		[100 46 27 16 1 0 1 0]
set tcp.recinput	[127 46 79 16 1 0 1 0]
set tcp.recinput.color	?recarm [155 0 0] [124 124 122]
set tcp.recinput.font 	[4]
set tcp.recinput.margin [0 0 0 0 .5 1 0 1 0]
set tcp.fxbyp		[206 46 11 16 1 0 1 0]
set tcp.fx		[217 46 16 16 1 0 1 0]
set tcp.env		[233 46 44 16 1 0 1 0] 		

set tcp.volume 		trackpanmode<4 [0 66 185 16 0 0 1 0] [0 66 140 16 0 0 1 0]
set tcp.volume.label	trackpanmode<4 [180 66 42 17 1 0 1 0] [135 66 42 17 1 0 1 0]
set tcp.volume.label.margin 		[3 0 3 0 0.5] 

;((>Pan<))
set tcp.pan             trackpanmode<4 [226 66 19 19 1 0 1 0] [178 66 19 19 1 0 1 0] 
set tcp.pan.label	trackpanmode<4 [239 67 37 17 1 0 1 0] [191 67 37 17 1 0 1 0]
set tcp.pan.label.margin [8 0 4 0]	

set tcp.width		trackpanmode>4 [229 66 19 19 1 0 1 0]

set tcp.width.label 		trackpanmode>4 [242 67 37 17 1 0 1 0]
set tcp.width.label.margin 	[8 0 4 0]


	Layout "Bellaire TCP Blue Fader" "Bellaire TCP/Blue Fader"
	set tcp.size	[311 90 242]
	EndLayout

	Layout "Bellaire TCP Green Fader" "Bellaire TCP/Green Fader"
	set tcp.size	[311 90 242]
	EndLayout

	Layout "Bellaire TCP Yellow Fader" "Bellaire TCP/Yellow Fader"
	set tcp.size	[311 90 242]
	EndLayout

	Layout "Bellaire TCP Red Fader" "Bellaire TCP/Red Fader"
	set tcp.size	[311 90 242]
	EndLayout

EndLayout

you have the same issues happening with the El Dorado Channel Strip layout for the MCP.

::

The default layout thing was something I struggled with trying to figure out right before launch and I still unclear to me exactly how it is established in Walter. I know you label one "default" and it is first upstream in code, but there seams to be some more subtleties I am missing to its declaration.

[lucas_LCS]

Originally Posted by Retro

The default layout thing was something I struggled with trying to figure out right before launch and I still unclear to me exactly how it is established in Walter. I know you label one "default" and it is first upstream in code, but there seams to be some more subtleties I am missing to its declaration.

The default is the layout not encased between the Layout and Endlayout statements.
I was putting a nested Default in there because I wanted it to be clearly selectable apart from the Global Default, which is chnageable by the user IIRC.

clear tcp.*
set tcp.size		[311 90 242]

	Layout "Default Blue Fader" "Blue Fader"
	set tcp.size	[311 90 242]
	EndLayout


Layout "Example Layout"

clear tcp.*
set tcp.size		[311 90 242]

	Layout "Example Blue Fader" "Blue Fader"
	set tcp.size	[311 90 242]
	EndLayout

EndLayout

In the example above, the first 2 lines are the default layout, the next 2 are nested in the default
The last one, "Example Blue Fader" is nested in the "Example Layout"


Global Settings:
================
the line: tcp_folderindent 13 near the top of the RTConfig should be in the top, non-WALTER global section.
any duplicates of this line below that section will overwrite the previous setting for it, since you can only set it once for the entire theme


Variables:
==========
It looks like you are only using the variables for the Master TCP.
I would comment out the variables in the other sections then:
- check all the layouts to confirm they are still working correctly.
- if they are, delete those variables.
- they are not, determine which ones are needed and delete the unused ones.

::

[Retro]

Originally Posted by lucas_LCS

The default is the layout not encased between the Layout and Endlayout statements.
I was putting a nested Default in there because I wanted it to be clearly selectable apart from the Global Default, which is chnageable by the user IIRC.

clear tcp.*
set tcp.size		[311 90 242]

	Layout "Default Blue Fader" "Blue Fader"
	set tcp.size	[311 90 242]
	EndLayout


Layout "Example Layout"

clear tcp.*
set tcp.size		[311 90 242]

	Layout "Example Blue Fader" "Blue Fader"
	set tcp.size	[311 90 242]
	EndLayout

EndLayout

In the example above, the first 2 lines are the default layout, the next 2 are nested in the default
The last one, "Example Blue Fader" is nested in the "Example Layout"


Global Settings:
================
the line: tcp_folderindent 13 near the top of the RTConfig should be in the top, non-WALTER global section.
any duplicates of this line below that section will overwrite the previous setting for it, since you can only set it once for the entire theme


Variables:
==========
It looks like you are only using the variables for the Master TCP.
I would comment out the variables in the other sections then:
- check all the layouts to confirm they are still working correctly.
- if they are, delete those variables.
- they are not, determine which ones are needed and delete the unused ones.

::

So if the layout statement is not declared at the top, it is interpreted as the "default" layout in the Walter and by making the layout statement at the top of the layout section we establish the layout as a "non-default" layout. After I went back into my code and started editing and rereading your post I had already started to come to this conclusion.

[Retro]

Originally Posted by lucas_LCS

Variables:
==========
It looks like you are only using the variables for the Master TCP.
I would comment out the variables in the other sections then:
- check all the layouts to confirm they are still working correctly.
- if they are, delete those variables.
- they are not, determine which ones are needed and delete the unused ones.

::

Yeah, there was stuff in there I figured I really didn't need, but I wasn't totally sure what it was doing so I was reluctant to take it out. I am getting more sure of myself and more knowledgeable, now, and more willing to slice and dice. I just trimmed RetroSonic down to 1.35M largely due to your intervention.