|
|
|
01-05-2019, 11:47 AM
|
#1
|
Human being with feelings
Join Date: May 2017
Location: Leipzig
Posts: 6,621
|
API: UndoExclude_Begin(), UndoExclude_End()
Sometimes I use functions, that'll create UndoPoints, even if it's not neccessary for ny script at all, spamming the UndoList for the user.
For that, I would love to exclude parts of my script from undo-management, with: UndoExclude_Begin(), UndoExclude_End()
That way, I could decide, what to include into an UndoState and what not.
That kind of precision is good for the user of the script, so I only Undo stuf necessary.
|
|
|
01-05-2019, 02:30 PM
|
#2
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,096
|
+1, could use this too
|
|
|
01-05-2019, 02:39 PM
|
#3
|
Human being with feelings
Join Date: Apr 2016
Location: ASU`ogacihC
Posts: 3,913
|
+1, would use it!
|
|
|
01-05-2019, 04:23 PM
|
#4
|
Human being with feelings
Join Date: Dec 2017
Posts: 302
|
+1 to this FR
|
|
|
01-20-2019, 02:08 PM
|
#5
|
Human being with feelings
Join Date: Jul 2010
Location: Slovakia
Posts: 2,588
|
+1 supporting
|
|
|
01-21-2019, 02:29 AM
|
#6
|
Human being with feelings
Join Date: Mar 2016
Posts: 1,239
|
+1 please
|
|
|
04-29-2019, 01:45 PM
|
#7
|
Human being with feelings
Join Date: Oct 2017
Location: Black Forest
Posts: 5,054
|
needs some love
|
|
|
04-29-2019, 01:55 PM
|
#8
|
Human being with feelings
Join Date: Jul 2016
Location: Los Angeles, CA
Posts: 1,701
|
I'm not a scripter (which is rather obvious from my posts lol) but I just wanted to chime in from the user perspective here.
The average user runs a LOT of scripts. For everything. Larger ones like Track Inspector and LBX Stripper, smaller ones like Julian's amazing MIDI scripts, etc.
Having to undo literally several times because a script created an undo point is a complete workflow killer. If I do something simple like transpose an item and have to hit undo 3 or 4 times to actually undo the command I just did it becomes really really tedious.
So please consider Mespotine's suggestion of UndoExclude_Begin(), UndoExclude_End(). It is really, really necessary. Especially since scripting is now going to become part of theme customization in Reaper 6.
|
|
|
04-29-2019, 02:06 PM
|
#9
|
Human being with feelings
Join Date: Mar 2016
Posts: 1,239
|
Yes please
|
|
|
04-30-2019, 06:20 AM
|
#10
|
Human being with feelings
Join Date: Apr 2014
Posts: 4,171
|
Yes - would make life so so much easier.
One of my scripts uses JSFX utility plugins. The easiest way to communicate with these is via the sliders (yes I know gmem can be used - but that can also be far fiddlier depending on what I'm trying to do).
As soon as I change a slider - unless I change it back within a certain (short) amount of time (again often requiring a bunch of annoying extra code to keep the functionality correct) - then unwanted undo points get created!
I want to be able to completely temporarily disable the undo system when I communicate with these utility JSFX - none of the changes ever want to be undone for these plugins. And then of course to re-enable the undo system once I'm done.
Would be awesome.
|
|
|
04-30-2019, 07:52 AM
|
#11
|
Human being with feelings
Join Date: Oct 2017
Location: Black Forest
Posts: 5,054
|
Yes, huge fan of lb0's stuff! Pretty please
|
|
|
05-20-2019, 09:12 AM
|
#12
|
Human being with feelings
Join Date: Nov 2015
Location: earth
Posts: 471
|
Yes, I too would love to see this functionality added. It is sorely needed for so many non-linear workflows where carefully managing undo history is really important.
|
|
|
05-20-2019, 09:26 AM
|
#13
|
Human being with feelings
Join Date: Jul 2016
Location: Los Angeles, CA
Posts: 1,701
|
Pretty please? This is starting to become a real drag when running multiple scripts. As a user I almost get PTSD using undo now because I don't know how many times I will have to hit undo to actually undo the thing I want. Workflow killer from both a user and a scripter standpoint.
|
|
|
05-20-2019, 11:49 AM
|
#14
|
Human being with feelings
Join Date: Sep 2013
Posts: 657
|
+1 it would be nice to have it in many scripting scenarios.
|
|
|
05-20-2019, 11:56 AM
|
#15
|
Human being with feelings
Join Date: Jun 2012
Location: Spain
Posts: 7,239
|
+1
But maybe it is not easy to do. That is why we don't have it.
|
|
|
05-21-2019, 05:35 AM
|
#16
|
Human being with feelings
Join Date: May 2017
Location: Leipzig
Posts: 6,621
|
Quote:
Originally Posted by heda
+1
But maybe it is not easy to do. That is why we don't have it.
|
I think too. I would also imagine, that the whole undo-system in Reaper needs an extensive overhaul, as it's very shaggy in many ways (undoing stuff that's should not be part of the undo-point, mostly markers).
So I think, it would be worth several dev-cycles to get it right.
Nevertheless, as much as we can do with Reaper at this point, we definately need a stable way of undoing/not undoing things or it will become a mess further and further.
Last edited by Meo-Ada Mespotine; 06-03-2019 at 07:30 AM.
|
|
|
06-02-2019, 09:11 AM
|
#17
|
Human being with feelings
Join Date: Sep 2008
Location: Sweden
Posts: 7,417
|
Quote:
Originally Posted by mespotine
Sometimes I use functions, that'll create UndoPoints, even if it's not neccessary for ny script at all, spamming the UndoList for the user.
For that, I would love to exclude parts of my script from undo-management, with: UndoExclude_Begin(), UndoExclude_End()
That way, I could decide, what to include into an UndoState and what not.
That kind of precision is good for the user of the script, so I only Undo stuf necessary.
|
Aha!
So that is what is going on with all those strange undo entries filling up my buffer, even though I do not touch the JSFX, just start/stop playing. And when the buffer grows beyond 3 MB or so, Reaper starts to stutter on play ( https://forum.cockos.com/showthread....28#post2141552).
Yes, this is very much needed.
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
|
|
|
07-01-2019, 09:09 AM
|
#18
|
Human being with feelings
Join Date: Jul 2016
Location: Los Angeles, CA
Posts: 1,701
|
Bumping this for good measure...
It's really a problem for both users and scripters alike at this point.
|
|
|
07-01-2019, 09:12 AM
|
#19
|
Human being with feelings
Join Date: Oct 2017
Location: Black Forest
Posts: 5,054
|
Yep, I concur. Huge +1
|
|
|
07-01-2019, 09:16 AM
|
#20
|
Human being with feelings
Join Date: May 2017
Location: Leipzig
Posts: 6,621
|
I'm still all in for this one
|
|
|
07-01-2019, 12:14 PM
|
#21
|
Human being with feelings
Join Date: Dec 2017
Posts: 302
|
+100500
|
|
|
07-01-2019, 03:00 PM
|
#22
|
Human being with feelings
Join Date: Apr 2014
Posts: 4,171
|
+inf - Yes please. Pretty please
|
|
|
07-06-2019, 01:35 AM
|
#23
|
Human being with feelings
Join Date: Feb 2019
Location: Southern Vermont
Posts: 864
|
Yes. This would be the thing to do
|
|
|
09-13-2019, 01:12 AM
|
#24
|
Human being with feelings
Join Date: May 2016
Posts: 2,065
|
+1 to have this taken care of sooner than later
I now have two custom scripts that would benefit from this and improve REAPER performance.
__________________
REAPER, just script it bro.
|
|
|
09-13-2019, 04:56 AM
|
#25
|
Human being with feelings
Join Date: Jan 2013
Posts: 1,126
|
+1
This might be one of the most requested thing from scripters
|
|
|
09-14-2019, 12:18 AM
|
#26
|
Human being with feelings
Join Date: May 2018
Location: Los Angeles
Posts: 1,719
|
+1 from me too.
__________________
Cheers... Andrew K
Reaper v6.80+dev0621 - June 21 2023 • Catalina • Mac Mini 2020 6 core i7 • 64GB RAM • OS: Catalina • 4K monitor • RME RayDAT card with Sync Card and extended Light Pipe.
|
|
|
09-14-2019, 12:53 PM
|
#27
|
Human being with feelings
Join Date: May 2017
Location: Leipzig
Posts: 6,621
|
Quote:
Originally Posted by lexaproductions
+1
This might be one of the most requested thing from scripters
|
And one of my hopes for v6.
So... +6
|
|
|
09-16-2019, 01:30 PM
|
#28
|
Human being with feelings
Join Date: May 2016
Posts: 2,065
|
It's my hope for REAPER v5.984
__________________
REAPER, just script it bro.
|
|
|
09-21-2019, 10:40 AM
|
#29
|
Human being with feelings
Join Date: Sep 2019
Posts: 2
|
+1 would definitely be helpful for future releases!
|
|
|
11-08-2019, 10:19 AM
|
#30
|
Human being with feelings
Join Date: May 2017
Location: Leipzig
Posts: 6,621
|
+FFFFF19BC1
|
|
|
11-20-2019, 08:02 AM
|
#31
|
Human being with feelings
Join Date: Jul 2016
Location: Los Angeles, CA
Posts: 1,701
|
Bumpy bumpy. Could really use some love on this from the developers. Scripters are having to do crazy workarounds just to try and limit the amount of undos. And I'm getting really tired of having to hit undo 4 times to undo the action I just triggered.
When you have this many scripters asking for something, you know it's something that is REALLY needed.
Thanks for your consideration.
|
|
|
11-24-2019, 02:53 AM
|
#32
|
Human being with feelings
Join Date: Oct 2017
Location: Black Forest
Posts: 5,054
|
A friendly v6 rc bump.
|
|
|
12-20-2019, 09:20 AM
|
#33
|
Human being with feelings
Join Date: May 2017
Location: Leipzig
Posts: 6,621
|
Jingle Bump, jingle bump, jingle all the way...
|
|
|
12-20-2019, 10:11 AM
|
#34
|
Human being with feelings
Join Date: Oct 2007
Location: home is where the heart is
Posts: 12,096
|
+1 from me too (again)
Personal use case example:
I was fixing/rewriting an SWS exported API function some time ago. Unlike in the original code which didn't create any undo point I used some Main_OnCommand() actions and things like SetEditCurPos() in the fix because it was easier to do ( ).
Now there's a report that this API function creates an unnecessary undo point because of this and I don't know how to solve it currently as we have no control over creating undo points when using native actions / parts of the API.
(Sure I could wrap it in an undo block but that again wouldn't be original behaviour).
Last edited by nofish; 12-20-2019 at 10:19 AM.
|
|
|
12-20-2019, 10:49 AM
|
#35
|
Human being with feelings
Join Date: Oct 2017
Location: Black Forest
Posts: 5,054
|
Triple bump!
|
|
|
12-21-2019, 09:50 AM
|
#36
|
Human being with feelings
Join Date: Jul 2016
Location: Los Angeles, CA
Posts: 1,701
|
It's Xmas time Devs. Would be a great addition under the tree!!
|
|
|
01-10-2020, 09:11 PM
|
#37
|
Human being with feelings
Join Date: Aug 2019
Posts: 853
|
Like Klangfarben, I'm no scripter, but I feel the effects of these issues as a user every day.
Quote:
Originally Posted by mespotine
I would also imagine, that the whole undo-system in Reaper needs an extensive overhaul, as it's very shaggy in many ways (undoing stuff that's should not be part of the undo-point, mostly markers).
So I think, it would be worth several dev-cycles to get it right.
Nevertheless, as much as we can do with Reaper at this point, we definately need a stable way of undoing/not undoing things or it will become a mess further and further.
|
I think this is bang on. The extra undo points are even more unwelcome when you consider the constant interrupts to the audio stream that are caused by the undo/redo actions, which I posted about here - https://forum.cockos.com/showthread.php?p=2223680
Justin weighed on that thread saying there was room for improvement and it's on the list. So hopefully this thread will also get a look in.
I'm also very much hoping that the undo system gets a proper overhaul. I know it's not a flashy new feature like embedded UI's or HiDPI functionality but it's crucial.
Don't get me wrong, I love both of those, but this is such an important ground-level function, it's something we're all using probably hundreds of times in a long session, so it's absolutely worth taking the time to make it the best it can be. I would be hugely grateful.
|
|
|
01-14-2020, 03:03 PM
|
#38
|
Human being with feelings
Join Date: Oct 2017
Location: Black Forest
Posts: 5,054
|
Bumperoni with Pesto and Parmesan!
The scripters of our community would really appreciate it
|
|
|
01-15-2020, 11:14 PM
|
#39
|
Human being with feelings
Join Date: Oct 2017
Location: Russia
Posts: 366
|
+1 from me, certainly a very necessary function
|
|
|
02-11-2020, 01:51 PM
|
#40
|
Human being with feelings
Join Date: Oct 2017
Location: Black Forest
Posts: 5,054
|
Monthly bump
|
|
|
Thread Tools |
|
Display Modes |
Linear Mode
|
Posting Rules
|
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
|
|
|
All times are GMT -7. The time now is 12:01 AM.
|