COCKOS
CONFEDERATED FORUMS
Cockos : REAPER : NINJAM : Forums
Forum Home : Register : FAQ : Members List : Search :

Go Back   Cockos Incorporated Forums > Other Software Discussion > WDL users forum

Reply
 
Thread Tools Display Modes
Old 01-17-2020, 09:21 AM   #1
Tale
Human being with feelings
 
Tale's Avatar
 
Join Date: Jul 2008
Location: The Netherlands
Posts: 3,046
Default [IPlug1] Fixed scratch buffers for disconnected I/O

I recently ran into a nasty but apparently obscure bug (it's >10 years old) in IPlug1: If the audio buffer size changes (increases) while inputs/outputs are disconnected, then the old pointer is still used instead of the new pointer. This resulted in crashing the host (Adobe Audition) along with the plug-in (tested with Martinic Lem Echo Music and Scanner Vibrato, as well as Schwa Bitter).

I have pushed a simple fix to the next branch of my IPlug fork:

https://github.com/TaleTN/WDL/commit...7d42b774d59d60
Tale is offline   Reply With Quote
Old 01-17-2020, 12:08 PM   #2
Nonlinear
Human being with feelings
 
Join Date: Apr 2018
Posts: 278
Default

Thank you for posting this “heads up” and fix.

Yes, it is frustrating when issues like this pop up after long periods of thinking “all is well”. I have found VST3 the most troublesome. What format did you see this in - or was it all?
Nonlinear is offline   Reply With Quote
Old 01-17-2020, 12:20 PM   #3
Tale
Human being with feelings
 
Tale's Avatar
 
Join Date: Jul 2008
Location: The Netherlands
Posts: 3,046
Default

Quote:
Originally Posted by Nonlinear View Post
Thank you for posting this “heads up” and fix.
You're welcome.

Quote:
Originally Posted by Nonlinear View Post
Yes, it is frustrating when issues like this pop up after long periods of thinking “all is well”.
Well, I didn't think it was frustrating... More surprising that we can still find bugs after such a long time.

Quote:
Originally Posted by Nonlinear View Post
I have found VST3 the most troublesome. What format did you see this in - or was it all?
VST 2.4 on Windows.
Tale is offline   Reply With Quote
Old 01-17-2020, 12:45 PM   #4
Nonlinear
Human being with feelings
 
Join Date: Apr 2018
Posts: 278
Default

Quote:
Originally Posted by Tale View Post
Well, I didn't think it was frustrating....
I bet your customer did when it crashed his/her project.


Quote:
Originally Posted by Tale View Post
VST 2.4 on Windows.
Now that IS a surprise! I have found VST2 very solid being so well established. Some hosts still don’t support VST3.

Last edited by Nonlinear; 01-17-2020 at 01:26 PM.
Nonlinear is offline   Reply With Quote
Old 01-18-2020, 02:02 AM   #5
Tale
Human being with feelings
 
Tale's Avatar
 
Join Date: Jul 2008
Location: The Netherlands
Posts: 3,046
Default

Quote:
Originally Posted by Nonlinear View Post
I bet your customer did when it crashed his/her project.
Yeah, probably...

Quote:
Originally Posted by Nonlinear View Post
Now that IS a surprise! I have found VST2 very solid being so well established. Some hosts still don’t support VST3.
Well, this is a bug in IPlugBase, so it has nothing to do with any plug-in API. I.e. there is no reason to assume this will not happen with VST3 as well.

However, I don't currently support VST3 at all, and since I mainly do virtual instruments (which require MIDI), I don't think I will add VST3 support anytime soon.
Tale is offline   Reply With Quote
Old 01-18-2020, 08:28 AM   #6
Nonlinear
Human being with feelings
 
Join Date: Apr 2018
Posts: 278
Default

Quote:
Originally Posted by Tale View Post
However, I don't currently support VST3 at all, and since I mainly do virtual instruments (which require MIDI), I don't think I will add VST3 support anytime soon.
Steinberg is pushing to “kill off” VST2 and VST3 supports MIDI too (supposedly better) so why avoid it? Take the plunge! 😩

Steinberg dropping VST2 actually created a nice side effect for plugin developers in that a ”line in the sand” has been drawn. VST2 is what it is - no future updates with changes or regression errors to worry about!
Nonlinear is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 03:01 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2020, vBulletin Solutions Inc.