Simple Draw Rectangle Control error

[SaschArt]

I made a Control to write a simple dynamic rectangle.

I have modified IControl.h Tale version as follows:

class IDrawRect : public IControl {
public:

	IDrawRect(IPlugBase* pPlug, IRECT* pR, const IColor* pColor)
	:   IControl(pPlug, pR), mColor(*pColor) {
			myRect.L=pR->L;	
			myRect.T=pR->T;
			myRect.R=pR->R;
			myRect.B=pR->B;
	}
	~IDrawRect() {}

	bool Draw(IGraphics* pGraphics);
	void SetRectFromPlug(IRECT* pR);
	void DelRectFromPlug();

protected:
	IColor mColor;
	IRECT myRect;
};

Also IControl.cpp:

bool IDrawRect::Draw(IGraphics* pGraphics) {
		return pGraphics->FillIRect(&mColor, &myRect);
}
void IDrawRect::SetRectFromPlug(IRECT* pR) {
		myRect.L=pR->L;	
		myRect.T=pR->T;
		myRect.R=pR->R;
		myRect.B=pR->B;
		SetDirty(false);
		Redraw();
}
void IDrawRect::DelRectFromPlug() {
		myRect.B=myRect.T;
		myRect.R=myRect.L;
		SetDirty(false);
		Redraw();
}

When I use to draw more rectangles it gives me errors: the first rectangle is deleted and the second one is incomplete.

[Tale]

In your SetRectFromPlug() you probably should also update mRECT (and maybe also mTargetRECT), because that's used by IGraphics:: Draw() (see IGraphics.cpp).

[SaschArt]

Still draw wrong, even with mTargetRECT update

[Tale]

Weird, because I've quickly added your code tyo Lem Echo Music, and it seems to work just fine. Maybe the bug is in the calling code? I just added this to my main plug-in's constructor:

IRECT r1(100, 100, 400, 300);
pGraphics->AttachControl(new IDrawRect(this, &r1, &COLOR_RED));
IRECT r2(150, 150, 450, 200);
pGraphics->AttachControl(new IDrawRect(this, &r2, &COLOR_GREEN));

Do note that I haven't tried SetRectFromPlug() or DelRectFromPlug(), because, like I said, that would require more work (i.e. updating at least mRECT).

[SaschArt]

Used in a static way there are no problems but dynamic yes.

In plugin constructor

	lfoRect = new IDrawRect(this, &IRECT(33, 327, 33+160, 327+6), &IColor(180,75,255,220));
	lfoRect1 = new IDrawRect(this, &IRECT(239, 327, 239+160, 327+6), &IColor(180,75,255,220));

In OnParamChange(int id)

	lfoRect->SetRectFromPlug(&IRECT(33+round((lfo_mid[0]-lfo_depth[0])*bar_width), 327, 33+round((lfo_mid[0]+lfo_depth[0])*bar_width), 327+6));

	lfoRect1->SetRectFromPlug(&IRECT(239+round((lfo_mid[0]-lfo_depth[0])*bar_width), 327, 239+round((lfo_mid[0]+lfo_depth[0])*bar_width), 327+6));

Rectangle from SetRectFromPlug() argument does not exceed the area initially draw in the constructor. But still draw wrong becouse of Dirty() I suppose

GetGUI()->IsDirty(&IRECT(33, 327, 33+160, 327+6)); in OnParamChange() seems to have no effect

[SaschArt]

The error was from some wrong parameters in OnParamChange(). No need to update mRECT, but must cover myRect