Go Back   Cockos Incorporated Forums > REAPER Forums > ReaScript, JSFX, REAPER Plug-in Extensions, Developer Forum

Reply
 
Thread Tools Display Modes
Old 07-11-2022, 04:40 PM   #81
OLSHALOM
Human being with feelings
 
Join Date: Sep 2019
Location: Austria
Posts: 443
Default

@X-Raym,

when I put this snippet:

Code:
if os_sep == "/" and colors[v] ~= colors_backup[v] then
local r, g, b = reaper.ColorFromNative( colors[v] )
colors[v] = reaper.ColorToNative(r, g, b)
end
before the last "end" of the loop (), it works ! :-)
OLSHALOM is offline   Reply With Quote
Old 07-12-2022, 05:17 AM   #82
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 9,874
Default

Well... lets try then... v0.6.12


I really encourage macos user to give feedback asap cause this kind of intermittent development is kinda annoying 😅I need to clear my mind about this bug. Thx !
X-Raym is offline   Reply With Quote
Old 07-12-2022, 12:25 PM   #83
tonalstates
Human being with feelings
 
tonalstates's Avatar
 
Join Date: Jun 2020
Posts: 656
Default

I know this is a PITA and I don't like being that guy because I must sound anoying af specially because I can't really give more feedback on what is happening but yeah, it's still exporting the opposite values here on my mac.

Like when I tweak the theme it's alright, until I export it, go back to another theme and back again to the edited one, it's the opposite colors.. Is there any way to troubleshoot this?
tonalstates is offline   Reply With Quote
Old 07-12-2022, 12:47 PM   #84
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 9,874
Default

I think I will just put an explicit checkbox 'invert channels' and let you guys do what work for you cause I'm lost with these contradictory reports.
X-Raym is offline   Reply With Quote
Old 07-13-2022, 02:25 AM   #85
OLSHALOM
Human being with feelings
 
Join Date: Sep 2019
Location: Austria
Posts: 443
Default

Quote:
Originally Posted by X-Raym View Post
I think I will just put an explicit checkbox 'invert channels' and let you guys do what work for you cause I'm lost with these contradictory reports.

I did a mistake by testing your code lines.
I reloaded the theme with the theme tweaker stayed open.
This didn't updated the colors in the script.
My fault, sorry for that.

Exchanging "r" and "b" in "color = reaper.ColorToNative(r, g, b)" for the function ExportTheme () doesn't do the job either.

Hope it helps and thanks again for your patience.
OLSHALOM is offline   Reply With Quote
Old 07-13-2022, 02:46 AM   #86
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 9,874
Default

One line below :

Code:
table.insert(t, v .. "=" .. ( color and reaper.ImGui_ColorConvertNative(color) or modes[v]) )

can you try


Code:
table.insert(t, v .. "=" .. color or modes[v])

instead ?


EDIT:
(if this last one doesnt work, try to invert r and b in the condition above)
X-Raym is offline   Reply With Quote
Old 07-13-2022, 03:19 AM   #87
OLSHALOM
Human being with feelings
 
Join Date: Sep 2019
Location: Austria
Posts: 443
Default

Quote:
Originally Posted by X-Raym View Post
One line below :

Code:
table.insert(t, v .. "=" .. ( color and reaper.ImGui_ColorConvertNative(color) or modes[v]) )

can you try


Code:
table.insert(t, v .. "=" .. color or modes[v])

instead ?


EDIT:
(if this last one doesnt work, try to invert r and b in the condition above)

It outputs this:

...ipts/X-Raym Scripts/Theme/X-Raym_Theme color tweaker.lua:162: attempt to concatenate a nil value (local 'color')
OLSHALOM is offline   Reply With Quote
Old 07-13-2022, 03:30 AM   #88
OLSHALOM
Human being with feelings
 
Join Date: Sep 2019
Location: Austria
Posts: 443
Default

Quote:
Originally Posted by X-Raym View Post

EDIT:
(if this last one doesnt work, try to invert r and b in the condition above)
makes no difference.

first message is ReaScriptError:

...ipts/X-Raym Scripts/Theme/X-Raym_Theme color tweaker.lua:162: attempt to concatenate a nil value (local 'color')

second message brings console output:

ImGui assertion failed: (g.CurrentWindowStack.Size == 1) && "Mismatched Begin/BeginChild vs End/EndChild calls: did you forget to call End/EndChild?"

by exporting via script.
OLSHALOM is offline   Reply With Quote
Old 07-13-2022, 04:02 AM   #89
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 9,874
Default

@OLSHALOM
Do you have a Zoom account, if yes, please create a room and contact me in PM. Thx.
X-Raym is offline   Reply With Quote
Old 07-13-2022, 04:56 AM   #90
OLSHALOM
Human being with feelings
 
Join Date: Sep 2019
Location: Austria
Posts: 443
Default

Quote:
Originally Posted by X-Raym View Post
@OLSHALOM
Do you have a Zoom account, if yes, please create a room and contact me in PM. Thx.
OK.
OLSHALOM is offline   Reply With Quote
Old 12-22-2022, 08:19 PM   #91
gdm_music
Human being with feelings
 
gdm_music's Avatar
 
Join Date: Sep 2022
Location: India
Posts: 128
Default

Got this Error
gdm_music is offline   Reply With Quote
Old 12-23-2022, 05:38 AM   #92
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 9,874
Default

@gdm_music
Weird.
X-Raym is offline   Reply With Quote
Old 03-22-2023, 11:19 AM   #93
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 9,874
Default v0.7.0

Finally went done to the infamous color swap bug! (thx cfillion for the concise function).


Quote:
* v0.7.0 (2023-03-22)
# Fixed channel swap on MacOS and Linux
+ Quit with ESC
# Restore initial theme button
# Better export naming
# Load new theme at export
# Restore button on the left

Next big step should be to work on zipped theme but no plan for it right now (may be a bit overkill).



This update took me the whole day, I had to install a linux virtual machine and learn tons of stuff just for that. if you want to support my work, check my signature, thx! 😉
X-Raym is offline   Reply With Quote
Old 04-03-2023, 12:17 AM   #94
tonalstates
Human being with feelings
 
tonalstates's Avatar
 
Join Date: Jun 2020
Posts: 656
Default

Hi X-raym, I wanted to try out the new release to see if the swap was fixed on my end but I get this error when trying to run the script

"X-Raym_Theme color tweaker.lua:168: bad argument #1 to 'match' (string expected, got nil)"
tonalstates is offline   Reply With Quote
Old 04-03-2023, 11:04 AM   #95
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 9,874
Default

@Tonalstates
Right at script launch?


What do you see if you print reaper.GetLastColorThemeFile() and press enter in Script: cfillion_Interactive ReaScript.lua ?





EDIT: Oh yes I remembered this issue:
https://forum.cockos.com/showpost.ph...37&postcount=6

Please bump this thread, it is outside of what I can do :S

Last edited by X-Raym; 04-03-2023 at 11:24 AM.
X-Raym is offline   Reply With Quote
Old 04-03-2023, 11:44 AM   #96
tonalstates
Human being with feelings
 
tonalstates's Avatar
 
Join Date: Jun 2020
Posts: 656
Default

So I don't know what happened but now it works xd and yeah, it was when first running the script.

I changed the theme a couple of times, which I didn't try yesterday heh and well now it works, I'll check on the swapping stuff later, thanks X-Raym!
tonalstates is offline   Reply With Quote
Old 04-03-2023, 12:56 PM   #97
OLSHALOM
Human being with feelings
 
Join Date: Sep 2019
Location: Austria
Posts: 443
Default

Quote:
Originally Posted by tonalstates View Post
So I don't know what happened but now it works xd and yeah, it was when first running the script.

I changed the theme a couple of times, which I didn't try yesterday heh and well now it works, I'll check on the swapping stuff later, thanks X-Raym!
I can second that behavior.
OLSHALOM is offline   Reply With Quote
Old 04-03-2023, 12:58 PM   #98
X-Raym
Human being with feelings
 
X-Raym's Avatar
 
Join Date: Apr 2013
Location: France
Posts: 9,874
Default

@OLSHALOM
What theme do you use ? Have you ever change theme ?
X-Raym is offline   Reply With Quote
Old 04-03-2023, 01:13 PM   #99
OLSHALOM
Human being with feelings
 
Join Date: Sep 2019
Location: Austria
Posts: 443
Default

Quote:
Originally Posted by X-Raym View Post
@OLSHALOM
What theme do you use ? Have you ever change theme ?
I had the same behavior like tonalstate.

First I got this error: "X-Raym_Theme color tweaker.lua:168: bad argument #1 to 'match' (string expected, got nil)"

Then changed the theme to default and a theme of mine. Suddenly it worked.
Sadly I couldn't replicate exactly what happened, sorry.

but the good news are, changing a color in your script exporting the theme with suffix MOD 1 and then reload the modded file via drag'n'drop from finder seems to work totally fine, as far as I can say now.

Last edited by OLSHALOM; 04-03-2023 at 02:04 PM.
OLSHALOM is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 01:19 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.