Old 04-07-2018, 04:03 AM   #1
Fabian
Human being with feelings
 
Fabian's Avatar
 
Join Date: Sep 2008
Location: Sweden
Posts: 5,528
Default Bug in Lock track height...

There seems to be a bug in the implementation of lock track height, where that property sometimes stops to work and the track has its height changed when zooming even though the toggle to lock track height is on. If I turn it off and then on again, things work again as expected, but then at some point (unclear when or how) it stops working again.

Licecap:


First you see that lock track height is checked, then I Ctrl+mousescroll the TCP, and you see that the track indeed changes height. Then I turn the toggle off and Ctr+scroll again and you see that the behavior is the same as it was with the toggle on. Then I toggle it again, and then you see that the track indeed has its height locked when Ctrl+scrolling.
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
Fabian is offline   Reply With Quote
Old 04-07-2018, 04:08 AM   #2
Fabian
Human being with feelings
 
Fabian's Avatar
 
Join Date: Sep 2008
Location: Sweden
Posts: 5,528
Default

The bug, if it now is that, occurs after I use my custom action to zoom to project. This action goes like:

Code:
SWS: Save selected item(s)
Item: Select all items
SWS: Vertical zoom to selected items
SWS: Horizontal zoom to selected items
Item: Unselect all items
SWS: Restore saved selected item(s)
Probably something in SWS does not play well with the lock track height feature...

I'm using SWS 2.9.7 built on Sep 20 2017
Reaper v5.78/x64 on W7x64
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
Fabian is offline   Reply With Quote
Old 04-07-2018, 04:51 AM   #3
nofish
Human being with feelings
 
nofish's Avatar
 
Join Date: Oct 2007
Location: home is where the heart is
Posts: 9,195
Default

I rebuilt your custom action here and can confirm.
Rather sure it's an SWS thing indeed.

I've created an issue on the SWS tracker about track height locking already, if you want you can add there and reference this thread.

edit:
Hopefully fixed in next SWS build.

Last edited by nofish; 04-07-2018 at 11:15 AM.
nofish is offline   Reply With Quote
Old 05-05-2018, 12:37 PM   #4
Larry Nobles
Human being with feelings
 
Join Date: Apr 2018
Posts: 1
Default Docker Height Locked and stuck there

Working fine ... then Docker Height locked. Can't change it for the life of me. Newbee to Reaper and may have clicked something, but need some advice. Not usable as it is for editing.
Thanks.

P.S. The LOCK TRACK HEIGHT button is NOT enabled. I've turned it on and off and no difference.
Larry Nobles is offline   Reply With Quote
Old 11-12-2019, 12:20 PM   #5
Fabian
Human being with feelings
 
Fabian's Avatar
 
Join Date: Sep 2008
Location: Sweden
Posts: 5,528
Default

At the SWS GitHub repo the case issued by nofish (https://github.com/reaper-oss/sws/issues/966) was closed on Feb 6, but I still have the same issue that I reported above.

If I lock track height, and then use my custom action given in post #2 above, track height locking gets messed up. The meny shows a check mark, but the track height lock is not functional.

I can accept that SWS: Vertical zoom to selected items would change the track height even if it is locked, but afterwards I would still expect track height locking to be in effect with the new height. That is not the way it works now.
__________________
// MVHMF
I never always did the right thing, but all I did wasn't wrong...
Fabian is offline   Reply With Quote
Old 11-12-2019, 12:46 PM   #6
Edgemeal
Human being with feelings
 
Edgemeal's Avatar
 
Join Date: Apr 2016
Location: ASU`ogacihC
Posts: 1,512
Default

FWIW, even REAPER zoom action can mess it up as I mentioned in pre-releases,..

https://forum.cockos.com/showpost.ph...66&postcount=8
Edgemeal is offline   Reply With Quote
Old 11-12-2019, 02:26 PM   #7
nofish
Human being with feelings
 
nofish's Avatar
 
Join Date: Oct 2007
Location: home is where the heart is
Posts: 9,195
Default

Quote:
Originally Posted by Fabian View Post
At the SWS GitHub repo the case issued by nofish (https://github.com/reaper-oss/sws/issues/966) was closed on Feb 6, but I still have the same issue that I reported above.
The linked GitHub issue originally only addressed that SWS vertical zoom actions didn't obey the (back then) newly introduced height locking, this was then changed at some point (and so the issue closed), but reverted later on as some weren't happy with changing existing behaviour.

Anyway, during that I totally forgot about your issue here, sorry.
It seems different to the linked issue as running SWS: Vertical zoom to selected items indeed seems to mess up Reaper's track height locking afterwards as you say (just tried again and can still reproduce with current Reaper/SWS).

So best probably if you'd open a new GitHub issue for that I think.

edit:
Actually I think it's a Reaper API bug, made a follow up post here:
https://forum.cockos.com/showthread.php?t=227045

edit2:
As cfillion pointed out in the linked thread, not a Reaper API bug.
So it's on SWS side to fix this I think.
Opened a new issue:
https://github.com/reaper-oss/sws/issues/1221

Last edited by nofish; 11-13-2019 at 05:37 PM.
nofish is offline   Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -7. The time now is 05:46 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2019, vBulletin Solutions Inc.