|
|
|
12-22-2022, 02:39 PM
|
#41
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by BenjyO
Hi FTC, I stumbled upon a bug (I think) with the Insert media into sample player on next played note(s) script but I can't seem to figure out what exactly is the issue. I have 2 MIDI controllers connected to the computer:
- Korg microKEY Air
- Novation Launchpad X
When I press the note(s) on the Korg keyboard, the script does what is expected. When I do the same on the Launchpad though, the script gets stuck on the "Play a note!" window and doesn't continue. It's like it's not obeying the note-off messages from the controller. It's also weird that it doesn't work when I try to "help" it by pressing the keys on the Korg keyboard (to get it to register note-offs). It remains stuck and I have to manually close the window.
Of course this wouldn't be an issue if I always had both controllers connected but since I sometimes use the Launchpad only, I'd like to see it work too.
I monitored the incoming MIDI messages from the Launchpad with ReaControlMIDI and it's normal. Sometimes (depending on how you press the pads) it sends aftertouch messages but only if you keep pressing the key. Most of the time it sends normal note-on + note-off pairs but as I described above, the script doesn't work in these cases either.
What do you think?
|
Hmmm, any chance one of your controllers sends 0x90 with velocity 0 as note-offs? Had a bug in the code where this wouldn't have been detected correctly. Just fixed it in a small update. Let me know if it makes a difference.
|
|
|
12-23-2022, 07:48 AM
|
#42
|
Human being with feelings
Join Date: Nov 2011
Posts: 308
|
Quote:
Originally Posted by FeedTheCat
Hmmm, any chance one of your controllers sends 0x90 with velocity 0 as note-offs? Had a bug in the code where this wouldn't have been detected correctly. Just fixed it in a small update. Let me know if it makes a difference.
|
Thank you very much. It works now.
It seems you were right. If I check the incoming MIDI messages with Protokol (Hexler app) it really shows a note-on event with 0 velocity. If I check the incoming MIDI messages with ReaControlMIDI I get something like this:
Quote:
25: 90 24 00 [Note Off] chan 1 note 36
26: 90 24 29 [Note On] chan 1 note 36 vel 41
27: 90 24 00 [Note Off] chan 1 note 36
28: 90 24 24 [Note On] chan 1 note 36 vel 36
29: 90 24 00 [Note Off] chan 1 note 36
30: 90 24 26 [Note On] chan 1 note 36 vel 38
31: 90 24 00 [Note Off] chan 1 note 36
32: 90 24 54 [Note On] chan 1 note 36 vel 84
33: 90 24 00 [Note Off] chan 1 note 36
34: 90 24 51 [Note On] chan 1 note 36 vel 81
35: 90 24 00 [Note Off] chan 1 note 36
36: 90 24 32 [Note On] chan 1 note 36 vel 50
37: 90 24 00 [Note Off] chan 1 note 36
38: 90 4C 58 [Note On] chan 1 note 76 vel 88
39: 90 4C 00 [Note Off] chan 1 note 76
|
I'm not that good with MIDI interpretation so I don't know if this is what you meant with "0x90 with velocity 0 as note-offs".
Anyway, it works. So thank you again!
|
|
|
12-23-2022, 08:53 AM
|
#43
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by BenjyO
I'm not that good with MIDI interpretation so I don't know if this is what you meant with "0x90 with velocity 0 as note-offs".
Anyway, it works. So thank you again!
|
Yep, that's what I meant. Nice!
|
|
|
12-28-2022, 01:50 AM
|
#44
|
Human being with feelings
Join Date: Sep 2022
Location: India
Posts: 128
|
Request
ability to turn off ME autoplay temporarily when the script is running
|
|
|
12-29-2022, 02:40 AM
|
#45
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by gdm_music
ability to turn off ME autoplay temporarily when the script is running
|
I get why you want this, it would have to be optional though, and the script doesn't have user options atm (which I would like to keep this way for simplicity's sake).
I have both autoplay and link toolbar buttons close to each other, which works for me. You could also make a custom action that turns off autoplay when running the script. Or if you want I can add some code and send you a custom version, let me know.
|
|
|
12-29-2022, 09:15 AM
|
#46
|
Human being with feelings
Join Date: Sep 2022
Location: India
Posts: 128
|
Quote:
Originally Posted by FeedTheCat
Or if you want I can add some code and send you a custom version, let me know.
|
That would be helpfull
|
|
|
12-29-2022, 02:23 PM
|
#47
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by gdm_music
That would be helpfull
|
Here you go
|
|
|
12-29-2022, 10:57 PM
|
#48
|
Human being with feelings
Join Date: Sep 2022
Location: India
Posts: 128
|
Thanks😄
|
|
|
12-30-2022, 06:16 PM
|
#49
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by souk21
edit: ah, I see in your screenshot that the dB label includes the value, which is not the case on macos
|
Oo, that new label was apparently added in v6.65. I updated the script so that volume linking works again.
@gdm_music
In case you want to update to make volume linking work: I added a line of code at the top of the script which you can uncomment for the autoplay feature.
|
|
|
12-30-2022, 09:01 PM
|
#50
|
Human being with feelings
Join Date: Sep 2022
Location: India
Posts: 128
|
thanks
|
|
|
11-06-2023, 01:51 AM
|
#51
|
Human being with feelings
Join Date: Jan 2011
Posts: 1,167
|
I want to say a huge thank you for this tool. Very helpful.
Disabling autoplay is also cool. But with autoplay turned off, the temporary mark does not appear on the selected files. Can I just trigger "Set temporary mark" action somewhere in the script?
|
|
|
11-06-2023, 02:59 AM
|
#52
|
Human being with feelings
Join Date: Jan 2011
Posts: 1,167
|
And another little thing.
Sometimes I run this script and realize that wrong RS5k instance was focused. So I hit Ctrl+Z to Undo and load previously loaded sample in RS5k but nothing happens because script does not create Undo Points. Then I disable the script and hit undo again but previous sample is lost and the only way if I don't remember what sample was loaded is to reload the project from last save.
I understand that I can avoid this by disabling script before UNDO but it's such a strong habbit: did something wrong > hit Ctrl+Z.
Is it possible to create undo points at every sample change or at least on script run to avoid data loss?
Hope it makes sense.
|
|
|
11-06-2023, 01:14 PM
|
#53
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by Daodan
I want to say a huge thank you for this tool. Very helpful.
Disabling autoplay is also cool. But with autoplay turned off, the temporary mark does not appear on the selected files. Can I just trigger "Set temporary mark" action somewhere in the script?
|
Hmmm, should be possible to set the temporary mark when a MIDI note is played.
Quote:
Originally Posted by Daodan
Is it possible to create undo points at every sample change or at least on script run to avoid data loss?
Hope it makes sense.
|
Should be possible, I'll try adding delayed undo points (e.g. if you don't change a sample in 2 secs you'll get an undo point). IIRC there was something wonky with undo though, so not sure if/how it will work.
|
|
|
11-07-2023, 04:23 AM
|
#54
|
Human being with feelings
Join Date: Jan 2011
Posts: 1,167
|
Quote:
Originally Posted by FeedTheCat
Hmmm, should be possible to set the temporary mark when a MIDI note is played.
|
Wouldn't that be too much activity? I mean the notes can be played quite often, hihat in sixteenth notes or something like that. Or do you mean only the first play after sample loading? But for me it would be enough to mark them when loading to RS5K.
Quote:
Originally Posted by FeedTheCat
Should be possible, I'll try adding delayed undo points (e.g. if you don't change a sample in 2 secs you'll get an undo point). IIRC there was something wonky with undo though, so not sure if/how it will work.
|
Nothing bad will happen in these 2 seconds, what could lead to the loss of the sample that was loaded before the script was launched? Although, again, for me it would probably be enough to have an undo point when running the script.
In any case, I'll be happy to test it
|
|
|
11-07-2023, 05:57 AM
|
#55
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
v1.3 is online:
- Temporarily disable auto-play by default
- Create delayed undo points
- Set temporary mark when previewing file by playing associated MIDI note (checks RS5K channel and note range)
- Using undo breaks link (v1.3.1)
Last edited by FeedTheCat; 11-07-2023 at 06:20 AM.
|
|
|
11-07-2023, 09:26 AM
|
#56
|
Human being with feelings
Join Date: Jan 2011
Posts: 1,167
|
Thank you.
Quote:
Set temporary mark when previewing file by playing associated MIDI note (checks RS5K channel and note range)
|
This unfortunately doesn't work.
UNDO stuff seems ok.
|
|
|
11-07-2023, 09:36 AM
|
#57
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by Daodan
This unfortunately doesn't work.
|
Hmm, stupid me. Was only thinking about live input, not recorded MIDI. I'll see what I can do.
|
|
|
11-08-2023, 12:55 PM
|
#58
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by Daodan
But for me it would be enough to mark them when loading to RS5K.
|
Let's just do this then. Added in v1.3.2.
|
|
|
11-08-2023, 03:57 PM
|
#59
|
Human being with feelings
Join Date: Jan 2011
Posts: 1,167
|
Quote:
Originally Posted by FeedTheCat
Let's just do this then. Added in v1.3.2.
|
It seems everything is working. Thank you so much!
|
|
|
11-09-2023, 01:18 PM
|
#60
|
Human being with feelings
Join Date: Jan 2011
Posts: 1,167
|
I remember that I mentioned that the Reaper interface is a little slow when the script is running. After that, you updated it and it became noticeably better, but still the meters jumped less smoothly. But now I don't notice it. I haven't seen anything updated regarding this in your script. Has this js_ReaScriptAPI been updated and become faster? Just curious.
|
|
|
11-09-2023, 03:20 PM
|
#61
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by Daodan
I remember that I mentioned that the Reaper interface is a little slow when the script is running. After that, you updated it and it became noticeably better, but still the meters jumped less smoothly. But now I don't notice it. I haven't seen anything updated regarding this in your script. Has this js_ReaScriptAPI been updated and become faster? Just curious.
|
It probably was the update that added undo points (had to add some optimizations to make it work). Was considering mentioning it in the changelog... but I didn't
|
|
|
11-09-2023, 11:20 PM
|
#62
|
Human being with feelings
Join Date: Jan 2011
Posts: 1,167
|
Quote:
Originally Posted by FeedTheCat
It probably was the update that added undo points (had to add some optimizations to make it work). Was considering mentioning it in the changelog... but I didn't
|
Well, it's a nice bonus track. Thank you.
|
|
|
11-17-2023, 12:59 AM
|
#63
|
Human being with feelings
Join Date: Jan 2011
Posts: 1,167
|
Hmm... Should this script work with the RS5K inside FX container?
|
|
|
11-17-2023, 04:06 AM
|
#64
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by Daodan
Hmm... Should this script work with the RS5K inside FX container?
|
Hopefully. With the new v1.4.0 update that I just pushed
|
|
|
11-17-2023, 07:20 AM
|
#65
|
Human being with feelings
Join Date: Jan 2011
Posts: 1,167
|
Quote:
Originally Posted by FeedTheCat
Hopefully. With the new v1.4.0 update that I just pushed
|
Works great. You're cool!
|
|
|
11-17-2023, 08:12 AM
|
#66
|
Human being with feelings
Join Date: May 2019
Location: Berlin
Posts: 2,164
|
Quote:
Originally Posted by Daodan
Works great. You're cool!
|
|
|
|
Thread Tools |
|
Display Modes |
Linear Mode
|
Posting Rules
|
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
|
|
|
All times are GMT -7. The time now is 01:50 PM.
|