Go Back   Cockos Incorporated Forums > Projects > Deprecated REAPER issue tracker > Open Bug

[3.12] Bypassing FX doesn't send note off Issue Tools
issueid=1323 10-10-2009 12:59 PM
Human being with feelings
[3.12] Bypassing FX doesn't send note off
When you bypass an instrument while it's playing, it doesn't send note off messages, so when you re-enable it there can be stuck notes.

http://forum.cockos.com/showthread.php?t=44121

When you bypass an instrument while it's playing, it doesn't send note off messages, so when you re-enable it there can be stuck notes.

To reproduce:
1. Create a track with a virtual instrument.
2. Set its sustain to full.
3. Insert a MIDI clip in the timeline with some long notes.
4. Start playback with the FX window open.
5. Bypass the instrument while it's on a note.
6. Stop playback.
7. Re-enable the instrument and hear the note still playing.

Expected behaviour:
When you bypass an instrument (or an effect that takes MIDI input, not much of a distinction in Reaper though), Reaper should send a note off message for every note currently playing.

I tried to think of a reason for leaving it this way but couldn't.
Issue Details
Issue Type Open Bug
Project Deprecated REAPER issue tracker
Category MIDI recording and playback
Status Confirmed
Priority 2
Affected Version 3.12
Fixed Version (none)
Users able to reproduce bug 3
Users unable to reproduce bug 0
Assigned Users (none)
Tags (none)

10-12-2009 05:26 AM
Human being with feelings
 
you know there're atleast 2 situations:
1. as you described when the fx is getting midi and produce audio
2. when the fx produce midi, this also can happen

so to send note off , it should be at each bypassed fx's entry + exit

(there's also a situation that a plug doesn't allow to modify midi,
so for this, sending note off, only on the fx's entry is enough, i think)
Reply
10-13-2009 01:05 AM
Human being with feelings
 
I realized since you can have more than one instrument that it should only send note off messages to the instruments being bypassed.

And yeah MIDI-generating plugins need some kind of treatment here too.
Reply
Reply

Issue Tools
Subscribe to this issue

All times are GMT -7. The time now is 01:26 AM.


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2021, vBulletin Solutions Inc.